-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-2080]: Add a custom enforcer rule to check for banned classes. #2688
Conversation
R: @davorbonaci . Feel free to add other maven experts in the team for review if needed. |
Thanks for the contribution ! Can you provide a quick abstract about the enforcer rule ? |
@jbonofre The enforcer rule that I have added in this PR basically looks at all the classes within the artifacts generated by Beam (like |
0311c79
to
f9c30c8
Compare
Retest this please |
Retest this please |
7728f07
to
4f2137c
Compare
Since development here, we've started migrating to Gradle. This same functionality might be handy in a Gradle task of some sort. Are you planning on working on this any more? |
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions. |
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull request
mvn clean verify
. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>
in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
org/apache/beam/Foo.class
or using wildcards likeorg/apache/maven/**
pluginManagement
and explicitly include them insdks
,examples
andrunners
.