[BEAM-2005] Move getScheme from FileSystemRegistrar to FileSystem #2757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalperi
reviewed
Apr 28, 2017
| * | ||
| * <p>The scheme is required to be unique among all | ||
| * <p>The {@link FileSystem#getScheme() scheme} is required to be unique among all |
| @@ -413,19 +408,11 @@ private static String parseScheme(String spec) { | |||
| */ | |||
| SCHEME_TO_REGISTRAR.clear(); | ||
| public static void setDefaultConfigInWorkers(PipelineOptions options) { | ||
| checkNotNull(options, "options"); | ||
| SCHEME_TO_FILESYSTEM.clear(); |
There was a problem hiding this comment.
we may need locks around this now -- there's a race condition if setDefaultConfigInWorkers is called while anything else is happening.
FWICT the Dataflow worker is the only one that initializes once at the beginning.
|
Eventually the plan is for HadoopFileSystem to return customizable schemes? |
Note that I needed to update FileSystems to instantiate the FileSystem(s) upfront instead of remembering the mapping from scheme to registrar.
|
Yes, the plan is for HadoopFileSystem to return customizable schemes, its just hardcoded right now since its an empty implementation. |
dhalperi
approved these changes
Apr 28, 2017
| */ | ||
| private static void loadFileSystemRegistrars() { | ||
| SCHEME_TO_REGISTRAR.clear(); | ||
| public static synchronized void setDefaultConfigInWorkers(PipelineOptions options) { |
There was a problem hiding this comment.
Also need to synchronize accessors to SCHEME_TO_FILESYSTEM -- specifically, #getFileSystemInternal.
…tion, remove double lookup within map
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that I needed to update FileSystems to instantiate the FileSystem(s) upfront instead of remembering the mapping from scheme to registrar during "registration" of the PipelineOptions.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.