Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libgeos-dev for ARM components of multi-arch Beam SDK Python containers #28036

Merged
merged 9 commits into from
Aug 16, 2023

Conversation

celeste-zeng
Copy link
Contributor

@celeste-zeng celeste-zeng commented Aug 16, 2023

fixes: #28035


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #28036 (356bf3d) into master (42ca3bf) will decrease coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #28036      +/-   ##
==========================================
- Coverage   72.31%   72.31%   -0.01%     
==========================================
  Files         678      678              
  Lines       99744    99744              
==========================================
- Hits        72127    72125       -2     
- Misses      26057    26059       +2     
  Partials     1560     1560              
Flag Coverage Δ
go 53.67% <ø> (ø)
python 82.86% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -80,6 +80,11 @@ RUN \
# Remove pip cache.
rm -rf /root/.cache/pip

# Required for using Beam Python SDK on ARM machines.
RUN if [ "${TARGETARCH}" = "arm64" ] ; then \
apt-get install libgeos-dev ; \
Copy link
Contributor

@tvalentyn tvalentyn Aug 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would suggest to move these statements to line 42 (keeping the statements inside one RUN command). note that apt temp files are cleared in line 44, and this command might require a prior call to apt update.

Also, did you run validatesconainerarm tests to verify this change ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, did you run validatesconainerarm tests to verify this change ?

you could post a link to GHA run on the PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall, pr intent looks good to me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Tried to put it around line 42 earlier but I don't think the if condition can be inserted between different package names after calling apt-get install.
  • I can't run on this branch because it is just a fork of the apache/beam master not the original master branch.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. I think we can install unconditionally to avoid extra complexity. I suspect it current version might fail without apt update.

@tvalentyn tvalentyn changed the title Add libgeos-dev for ARM components of multi-arch Beam SDK Python 3.11 containers Add libgeos-dev for ARM components of multi-arch Beam SDK Python containers Aug 16, 2023
@celeste-zeng
Copy link
Contributor Author

Run Python ValidatesContainer Dataflow ARM 3.11

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @tvalentyn for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@celeste-zeng
Copy link
Contributor Author

Run Python ValidatesContainer Dataflow ARM 3.11

@tvalentyn
Copy link
Contributor

LGTM

@tvalentyn tvalentyn merged commit f737974 into apache:master Aug 16, 2023
89 of 90 checks passed
aleksandr-dudko pushed a commit to aleksandr-dudko/beam that referenced this pull request Aug 17, 2023
aleksandr-dudko pushed a commit to aleksandr-dudko/beam that referenced this pull request Aug 18, 2023
@celeste-zeng celeste-zeng deleted the fix-py311 branch August 21, 2023 17:27
lostluck added a commit that referenced this pull request Aug 22, 2023
… Beam SDK Python containers (#28112)

* Add libgeos-dev for ARM

* remove double command

* Try format fix

* fix format

* fix ==

* revert changes to follow convention

* formatting

* Fix package not found error.

* install the package regardless

---------

Co-authored-by: Celeste Zeng <61256376+celeste-zeng@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Multi-arch Beam SDK Python 3.11 container missing libgeos-dev for ARM
2 participants