-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#28187] Add standalone prism validates runner precommit #28487
Conversation
Codecov Report
@@ Coverage Diff @@
## master #28487 +/- ##
==========================================
+ Coverage 72.23% 72.24% +0.01%
==========================================
Files 684 684
Lines 100855 100862 +7
==========================================
+ Hits 72855 72872 +17
+ Misses 26420 26411 -9
+ Partials 1580 1579 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Assigning reviewers. If you would like to opt out of this review, comment R: @jrmccluskey for label go. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Gentle Ping. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
name: PreCommit GoPrism |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you validated that this action passes on a fork of the repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically no. But I have no reason to believe it won't work.
This file is copied from GoPortable, with GoPortable switched with GoPrism, and the new gradle command. I've been running the new gradle command the whole time to get this working.
I also somehow ended up with a beam repo branch rather than a fork branch.... I don't know how that happened. Something clearly changed with my usual flow. That aside...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge this in, and run the dispatch right away, and I'll be ready to disable the auto-runs if that manual kick fails.
Not ideal, but I'm confident.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, that failed.
Somehow it doesn't have a go.mod file in the beam/sdks/ directory, so it can't build a prism instance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When. I was adding the govulncheck action it was funky about that, I had to specify the working directory to be the sdks directory and let it run there rather than specifying the path to the directory from Beam root. Might be a place to start
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. I think the issue is that it's building from the beam directory rather than beam/sdks. Changing directories before building the prism binary should sort it out.
Not entirely sure why it works locally for me, since that should be the same as well... interesting.
Add a github action precommit for the standalone prism runner. Standalone prism uses job specified environments (usually docker containers), by default.
Part of #28187
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.