Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flink Runner] Add UseDataStreamForBatch option to Flink runner to enable batch execution on DataStream API #28614

Merged
merged 8 commits into from Oct 27, 2023

Conversation

jto
Copy link
Contributor

@jto jto commented Sep 22, 2023

This PR is just #25742 updated. It also include the changes in #28609 which should be merged first.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@jto
Copy link
Contributor Author

jto commented Sep 27, 2023

Tests are failing while publishing results which seems unrelated to those changes...

@jto
Copy link
Contributor Author

jto commented Sep 27, 2023

assign set of reviewers

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@jto jto marked this pull request as draft September 27, 2023 15:39
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Reminder, please take a look at this pr: @kennknowles

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@jto jto marked this pull request as ready for review October 16, 2023 19:12
@github-actions
Copy link
Contributor

Reminder, please take a look at this pr: @kennknowles

Jiangjie Qin and others added 5 commits October 26, 2023 13:13
Modify the FlinkRunner to use DataStream API for batch job execution if
UseDataStreamForBatch is set to true.
DataStream execution path of batch jobs.
@jto
Copy link
Contributor Author

jto commented Oct 26, 2023

Hey @tvalentyn !
This PR is another improvement on the Flink runner that never got merged.
Could you please take a look at it too 🙏

CHANGES.md Outdated Show resolved Hide resolved
runners/flink/flink_runner.gradle Outdated Show resolved Hide resolved
@tvalentyn tvalentyn merged commit 1f7e882 into apache:master Oct 27, 2023
21 of 25 checks passed
@Abacn
Copy link
Contributor

Abacn commented Nov 28, 2023

It appears this change may also caused Flink ValidatesRunner to became extremely flaky: https://github.com/apache/beam/actions/workflows/beam_PostCommit_Java_ValidatesRunner_Flink.yml?page=6&query=event%3Aschedule

Although this test suite has always been flaky (~30% fail rate), prior to Oct 27th it became extremely flaky (<5% success rate)

Some example errors:

testAfterProcessingTimeContinuationTriggerUsingState

java.lang.AssertionError: Second Triggered sum/Values/Values/Map/ParMultiDo(Anonymous).output: 
Expected: iterable with items [<42>] in any order
     but: no match for: <84>
testTeardownCalledAfterExceptionInStartBundleStateful

java.lang.AssertionError: Expected to have a processing method throw an exception
	at org.junit.Assert.fail(Assert.java:89)
	at org.apache.beam.sdk.transforms.ParDoLifecycleTest$ExceptionThrowingFn.after(ParDoLifecycleTest.java:460)
testTriggeredLatestSingleton

org.apache.beam.sdk.Pipeline$PipelineExecutionException: java.lang.IllegalArgumentException: PCollection with more than one element accessed as a singleton view.
	at org.apache.beam.runners.flink.TestFlinkRunner.run(TestFlinkRunner.java:75)
	at org.apache.beam.sdk.Pipeline.run(Pipeline.java:321)
	at org.apache.beam.sdk.testing.TestPipeline.run(TestPipeline.java:398)
Caused by: java.lang.IllegalArgumentException: PCollection with more than one element accessed as a singleton view.
	at org.apache.beam.sdk.values.PCollectionViews$SingletonViewFn2.apply(PCollectionViews.java:412)
	at org.apache.beam.sdk.values.PCollectionViews$SingletonViewFn2.apply(PCollectionViews.java:339)

Abacn added a commit to Abacn/beam that referenced this pull request Jan 11, 2024
…er to enable batch execution on DataStream API (apache#28614)"

This reverts commit 1f7e882.
kkdoon pushed a commit to twitter-forks/beam that referenced this pull request Feb 7, 2024
…able batch execution on DataStream API (apache#28614)

Co-authored-by: Jiangjie Qin <jqin@jqin-mn1.internal.linkedin.cn>
Co-authored-by: tvalentyn <tvalentyn@users.noreply.github.com>
Abacn added a commit to Abacn/beam that referenced this pull request Mar 25, 2024
…er to enable batch execution on DataStream API (apache#28614)"

This reverts commit 1f7e882.
Abacn added a commit to Abacn/beam that referenced this pull request Mar 25, 2024
…er to enable batch execution on DataStream API (apache#28614)"

This reverts commit 1f7e882.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants