Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade checkerframework to 3.42.0 #29961

Merged
merged 1 commit into from Jan 18, 2024
Merged

Upgrade checkerframework to 3.42.0 #29961

merged 1 commit into from Jan 18, 2024

Conversation

kennknowles
Copy link
Member

@kennknowles kennknowles commented Jan 9, 2024 •
edited

Released December 2023 could be useful

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label Jan 9, 2024
@kennknowles
Copy link
Member Author

kennknowles commented Jan 9, 2024 •
edited

This introduces a bunch of false positives that I believe are true errors, such as typetools/checker-framework#6389. I am attempting other versions of checker to see if there is one that makes sense to upgrade to.

I was wrong that these are false positives. They are all correct issues to flag. Fixing them improved the code quality, as usual.

@kennknowles kennknowles mentioned this pull request Jan 10, 2024
Closed
@kennknowles kennknowles force-pushed the upgrade-checkerframework branch 2 times, most recently from 6e74ddb to 1ad8c7b Compare January 11, 2024 13:01
@github-actions github-actions bot added the spark label Jan 11, 2024
@kennknowles kennknowles force-pushed the upgrade-checkerframework branch 2 times, most recently from 6731381 to 1f978fd Compare January 11, 2024 17:47
@kennknowles kennknowles marked this pull request as ready for review January 11, 2024 18:19
@github-actions GitHub Actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@kennknowles
Copy link
Member Author

assign set of reviewers

@kennknowles kennknowles changed the title Upgrade checkerframeworkt to 3.42.0 Upgrade checkerframework to 3.42.0 Jan 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label java.
R: @Abacn for label build.
R: @chamikaramj for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@kennknowles
Copy link
Member Author

Ping - this upgrade is a noop unless I messed up. Just minor refactors that ensure side effects cannot invalidate preconditions, since checker has improved its precision.

chamikaramj
chamikaramj approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@chamikaramj chamikaramj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

runners/spark/spark_runner.gradle Outdated
@@ -25,9 +25,11 @@ applyJavaNature(
archivesBaseName: (project.hasProperty('archives_base_name') ? archives_base_name : archivesBaseName),
exportJavadoc: (project.hasProperty('exportJavadoc') ? exportJavadoc : true),
classesTriggerCheckerBugs: [
'Aggregators': 'TODO: file bug',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to leave TODOs here ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch - added a link to where they said they are working on it.

@kennknowles
Upgrade checkerframework to 3.42.0
65811ee 
This includes improvements in checker's safety. Files that needed adjustment
were adjusted, rather than suppressing the warning.
@kennknowles kennknowles merged commit 8772389 into apache:master Jan 18, 2024
40 checks passed
@kennknowles kennknowles deleted the upgrade-checkerframework branch January 18, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chamikaramj chamikaramj chamikaramj approved these changes

Assignees
No one assigned
Labels
aws build core dataflow extensions flink gcp io java jdbc mongodb Next Action: Reviewers protobuf runners sorter spark
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kennknowles @chamikaramj