Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix core SDK misuse of "provided" dep for everit_json_schema #30780

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

kennknowles
Copy link
Member

@kennknowles kennknowles commented Mar 28, 2024

Fixes #30776

The core SDK has a hard dependency on org.everit.json.schema. Because it was thought of as "optional" it was marked provided. But provided means that the expected runtime will provide a library. It should not be used for "optional". Optionality is achieved by factoring logic into separate modules which a user may choose to depend on or not. In this case, the core SDK has a compile time and runtime dependency on this, so this PR fixes this one dependency (among many) to be correct.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the java label Mar 28, 2024
@kennknowles
Copy link
Member Author

@Polber this is the "more correct" solution but it does change the core SDK deps so probably want @Abacn to look at it.

(it seems like someone wanted this functionality in core but also didn't want core to depend on this and you just can't have it both ways or you get problems like #30776)

Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, yeah agree it should be implemented. We have similar problem for provided dependencies and the same solution adopted

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @m-trieu for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn Abacn merged commit 2f8854a into apache:master Mar 28, 2024
20 checks passed
@kennknowles kennknowles deleted the json-better branch March 28, 2024 18:01
hjtran pushed a commit to hjtran/beam that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Beam YAML WriteToJson fails on Beam 2.55
2 participants