Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java-extension-sql]Beam Sql doesn't honor aliases because of BeamAggregateProjectMergeRule optimization #30902

Merged
merged 5 commits into from Apr 10, 2024
Merged

[java-extension-sql]Beam Sql doesn't honor aliases because of BeamAggregateProjectMergeRule optimization #30902

merged 5 commits into from Apr 10, 2024

Conversation

brachi-wernick
Copy link
Contributor

Fixes #30498

See full discussion

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 9, 2024

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

kennknowles
kennknowles requested changes Apr 9, 2024
View reviewed changes
Copy link
Member

@kennknowles kennknowles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I have one little request for keeping the test but marking it ignored. And is it possible to add a test like the examples from the bug, so it would fail without your change? (to make sure no one else undoes your work)

...est/java/org/apache/beam/sdk/extensions/sql/impl/rule/BeamAggregateProjectMergeRuleTest.java Show resolved Hide resolved
...est/java/org/apache/beam/sdk/extensions/sql/impl/rule/BeamAggregateProjectMergeRuleTest.java Show resolved Hide resolved
@kennknowles kennknowles merged commit c218864 into apache:master Apr 10, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennknowles kennknowles kennknowles approved these changes

Assignees
No one assigned
Labels
extensions java sql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Beam Sql is ignoring aliases fields in some situations which causes to huge data loss
2 participants
@brachi-wernick @kennknowles