Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Source type for BigTable and Kafka stress tests #30999

Merged
merged 6 commits into from
Apr 22, 2024

Conversation

akashorabek
Copy link
Contributor

@akashorabek akashorabek commented Apr 16, 2024

Replaced PeriodicImpulse source to SyntheticUnboundedSource for BigTable and Kafka stress tests since there is a difference in throughput and effiency.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@akashorabek akashorabek changed the title Test cases improvement Replace Source type for BigTable and Kafka stress tests Apr 16, 2024
@akashorabek akashorabek marked this pull request as ready for review April 17, 2024 23:55
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @johnjcasey added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions github-actions bot added infra and removed infra labels Apr 18, 2024
@github-actions github-actions bot added infra and removed infra labels Apr 18, 2024
@Abacn
Copy link
Contributor

Abacn commented Apr 22, 2024

Another PR used strimzi Kafka server #30967 found not working with apache-beam-testing project (cc: @volatilemolotov). Are the kafka k8s change tested, or could you please share a Kafka ST test result on this PR?

Bigtable changes LGTM

@akashorabek
Copy link
Contributor Author

akashorabek commented Apr 22, 2024

Yes, kafka k8s changes were tested. Here are the links to tests that use this changes:

Write kafka test
Read kafka test

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Abacn Abacn merged commit 1a5dc1c into apache:master Apr 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants