Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch #31513

Conversation

kennknowles
Copy link
Member

Tests run on GHA should be queued shortly.

@github-actions github-actions bot added the build label Jun 5, 2024
Copy link
Contributor

github-actions bot commented Jun 5, 2024

Test Results

12 files  + 4  12 suites  +4   1h 40m 37s ⏱️ + 17m 33s
15 tests +11  15 ✅ +11  0 💤 ±0  0 ❌ ±0 
15 runs  + 1  15 ✅ + 1  0 💤 ±0  0 ❌ ±0 

Results for commit 257546e. ± Comparison against base commit 96766f2.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jun 5, 2024

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-2.57.0@96766f2). Learn more about missing BASE report.

Current head 14d2ebd differs from pull request most recent head 257546e

Please upload reports for the commit 257546e to get more accurate results.

Additional details and impacted files
@@                Coverage Diff                @@
##             release-2.57.0   #31513   +/-   ##
=================================================
  Coverage                  ?   71.14%           
  Complexity                ?     3005           
=================================================
  Files                     ?     1055           
  Lines                     ?   133387           
  Branches                  ?     3248           
=================================================
  Hits                      ?    94902           
  Misses                    ?    35357           
  Partials                  ?     3128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kennknowles kennknowles force-pushed the postcommit_validation_pr branch 2 times, most recently from 86d75fc to d21fca6 Compare June 17, 2024 21:50
@kennknowles
Copy link
Member Author

kennknowles commented Jun 24, 2024

beam_PostCommit_XVR_GoUsingJava_Dataflow.yml

Two tasks failed (https://ge.apache.org/s/765iszy4taves/failure) the Dataflow Java and Python container build and push:

EDIT: confirmed this workflow file has no successful runs against master

@kennknowles
Copy link
Member Author

beam_PostCommit_Java_PVR_Spark_Batch.yml

This has been flaky for a long time, then red for a minute, then now green on master. Looking into whether this is just luck or something changed. I will verify whether it is in a perma-red state on the release branch and whether we care about the cause enough to stop the release.

@kennknowles
Copy link
Member Author

Looking into it, the tests that fail each time are different. There is overlapping passing of all ValidatesRunner tests for the Spark portable runner, but something is flaky. I don't think it needs to block.

@kennknowles
Copy link
Member Author

beam_PostCommit_XVR_Direct.yml

Has occasional green runs but they are practically a rounding error. This suite does not carry signal we can use.

@kennknowles
Copy link
Member Author

Release is finalized. Those red test suites can be dealt with as appropriate afterwards.

@kennknowles kennknowles deleted the postcommit_validation_pr branch June 26, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant