[BEAM-2247] implement date functions #3207
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @jbonofre |
|
Can you rebase please ? |
|
sure! |
xumingming
force-pushed
the
BEAM-2247-date-functions
branch
from
48bac03
to
17a07b1
Compare
|
Rebase done. |
xumingming
force-pushed
the
BEAM-2247-date-functions
branch
from
17a07b1
to
0b94e62
Compare
|
Rebase(again) done. |
mingmxu
reviewed
Jun 8, 2017
| * <p>Returns the current time in the session time zone, in a value of datatype | ||
| * TIMESTAMP WITH TIME ZONE. | ||
| */ | ||
| public class BeamSqlCurrentTimeExpression extends BeamSqlExpression { |
There was a problem hiding this comment.
can this cover BeamSqlCurrentTimestampExpression as well?
| @Override public BeamSqlPrimitive evaluate(BeamSQLRow inputRecord) { | ||
| Date date = opValueEvaluated(0, inputRecord); | ||
| long time = date.getTime(); | ||
| time -= 8 * 3600; |
There was a problem hiding this comment.
Thanks for the catch, the shift is wrong.
|
LGTM Thanks @xumingming |
mingmxu
approved these changes
Jun 9, 2017
xumingming
force-pushed
the
BEAM-2247-date-functions
branch
from
a88fd78
to
3270152
Compare
|
Rebase(again, again) done. |
|
CC: @takidau @kennknowles can you take a peak here? |
|
R: @jbonofre |
|
Merged on |
|
Thanks @jbonofre @xumingmin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@xumingmin @jbonofre can you guys take a look at this one?