Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Additional PTransform Inputs in Transform Nodes #3337

Merged
merged 1 commit into from Jun 9, 2017

Conversation

tgroh
Copy link
Member

@tgroh tgroh commented Jun 9, 2017

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify.
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

@tgroh
Copy link
Member Author

tgroh commented Jun 9, 2017

@kennknowles

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 70.686% when pulling 2656abe on tgroh:all_inputs into 1c6861f on apache:master.

@kennknowles
Copy link
Member

Actually last time the postcommit caught it so I've canceled the ValidatesRunner to trim queue length.

@kennknowles
Copy link
Member

Strange postcommit result. The reactor indicates SUCCESS for all modules, yet there is an exception-looking message in the log that Jenkins pulls out. It is validation of how a bad password is reported to the user in JmsIO.

@kennknowles
Copy link
Member

Can you add deliberate remarks about which commit are being reverted / cherry-picked in the new commit message?

@kennknowles
Copy link
Member

Reviewed diff <(git show 9336230d2a5c18bae89908bcd60db8ea96b7906d) <(git show 2656abe), noted the split of all consumers from per-element consumers. LGTM.

Update DirectGraph to have All and Non-Additional Inputs

This reverts commit 247f9bc
@asfgit asfgit merged commit 696f8b2 into apache:master Jun 9, 2017
asfgit pushed a commit that referenced this pull request Jun 9, 2017
…Nodes

  Roll-forward Include Additional PTransform inputs in Transform Nodes
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 696f8b2 on tgroh:all_inputs into ** on apache:master**.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants