Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-2447] Reintroduces DoFn.ProcessContinuation (Dataflow worker compatibility part) #3383

Closed
wants to merge 2 commits into from
Closed

[BEAM-2447] Reintroduces DoFn.ProcessContinuation (Dataflow worker compatibility part) #3383

wants to merge 2 commits into from

Conversation

jkff
Copy link
Contributor

@jkff jkff commented Jun 16, 2017

Prerequisite for #3360. Will need a Dataflow worker update too.

R: @tgroh

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.001%) to 70.693% when pulling 8ee3b72 on jkff:process-cont-base into 0cabdf6 on apache:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 70.665% when pulling 8ee3b72 on jkff:process-cont-base into 0cabdf6 on apache:master.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 33f6d6d on jkff:process-cont-base into ** on apache:master**.

@jkff
Copy link
Contributor Author

jkff commented Jun 23, 2017

OK, PTAL, this is compatible with the worker. Alternatively R: @kennknowles works too

@kennknowles
Copy link
Member

LGTM

@asfgit asfgit closed this in 95e6bbe Jun 27, 2017
@jkff jkff deleted the process-cont-base branch June 27, 2017 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jkff @coveralls @kennknowles