Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-2353] Unbundle Context and WindowedContext. #3539

Closed
wants to merge 2 commits into from
Closed

[BEAM-2353] Unbundle Context and WindowedContext. #3539

wants to merge 2 commits into from

Conversation

reuvenlax
Copy link
Contributor

Remove the unnecessary classes, and inline the parameters. This is not a backwards-compatible change, however these classes are marked as @experimental.

R: @kennknowles

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 70.707% when pulling 40e15d8 on reuvenlax:unbundle_filename_policy_context into 0e89df3 on apache:master.

kennknowles
kennknowles approved these changes Jul 12, 2017
View reviewed changes
Copy link
Member

@kennknowles kennknowles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The style is off but I'll autoformat.

@asfgit asfgit closed this in 5f972e8 Jul 13, 2017
@reuvenlax reuvenlax deleted the unbundle_filename_policy_context branch December 9, 2018 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennknowles kennknowles kennknowles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@reuvenlax @coveralls @kennknowles