Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-2675] Consolidate ValidatesRunner suite building into one file. #3631

Closed
wants to merge 1 commit into from

Conversation

jasonkuster
Copy link
Contributor

Signed-off-by: Jason Kuster jasonkuster@google.com

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

This change reduces duplication in the ValidatesRunner tests and avoids the proliferation of additional files in favor of the minimum information necessary (runner name, maven args to run) for the test.

R: @kennknowles

Feel free to punt to someone else -- assigning to you as you've been working with the ValidatesRunner tests for a while.

Signed-off-by: Jason Kuster <jasonkuster@google.com>
Copy link
Member

@kennknowles kennknowles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I think this makes the Jenkins job code a bit less discoverable. I would prefer that there be a central library that contains the logic, but each of the individual jobs still gets their own file.

@markflyhigh
Copy link
Contributor

Python validates runner test in the future will have similar separated builds like java. So we may also want to leave a 'port' for Python.

@jkff
Copy link
Contributor

jkff commented Dec 16, 2017

This is likely quite a bit out of date; is it still relevant?

@jkff
Copy link
Contributor

jkff commented Feb 7, 2018

Closing per stale PR policy (60 days of inactivity), please reopen if needed.

@jkff jkff closed this Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants