Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-2884] Move DoFnInfo to SDK util #3858

Merged
merged 2 commits into from Sep 19, 2017
Merged

Conversation

kennknowles
Copy link
Member

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Previously, the DoFnInfo wrapped things just enough for Dataflow to execute a DoFn without much context. The Java SDK harness has the same need, and relies on DoFnInfo. Effectively, DoFnInfo is the UDF that the Java SDK harness understands.

This also helps to break the dependency between the Java SDK harness and the Dataflow runner codebase, by just moving it to be an allowed dependency.

This will require a new worker image.

@kennknowles
Copy link
Member Author

R: @tgroh

Previously, the DoFnInfo wrapped things just enough for Dataflow to execute a
DoFn without much context. The Java SDK harness has the same need, and relies
on DoFnInfo. Effectively, DoFnInfo is the UDF that the Java SDK harness
understands.
@kennknowles
Copy link
Member Author

Run Dataflow ValidatesRunner

@asfgit asfgit merged commit 056b720 into apache:master Sep 19, 2017
asfgit pushed a commit that referenced this pull request Sep 19, 2017
  Update Dataflow container version to 20170918
  Move DoFnInfo to SDK util
@kennknowles kennknowles deleted the DoFnInfo branch September 29, 2017 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants