[BEAM-2576] Reflect portability proto changes in Go #3983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @kennknowles |
|
Pick any package names you like - it should be as idiomatic as possible. I am not particularly attached even to the Java names. |
|
BTW I knew this needed doing but decided to leave it for a minute since there were enough conflicts and revisions needed on the first PR. |
|
We should figure a way to either automate the headers or exclude them from the RAT check. I'll check the policy and also tooling. |
asfgit
pushed a commit
that referenced
this pull request
Oct 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Go code according to the proto changes in #3924.
Also pick nicer package names in Go.