[BEAM-2829] Add an option for dataflow job labels.

[aaltay]

CP #3990

[aaltay]

R: @reuvenlax

[reuvenlax]

Is there any way to test this?

[aaltay]

I started a job a verified the labels are present in the dataflow UI. I can add a unit test to verify the proto fields set correctly.

cc: @zongweiz How is this tested in Java SDK?

[reuvenlax]

Unit test sounds good for now.

…

On Fri, Oct 13, 2017 at 2:42 PM, Ahmet Altay ***@***.***> wrote: I started a job a verified the labels are present in the dataflow UI. I can add a unit test to verify the proto fields set correctly. cc: @zongweiz <https://github.com/zongweiz> How is this tested in Java SDK? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3993 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AUGE1dMVFq-0Go90yd_mDyvAMYgI8wLgks5sr9k5gaJpZM4P5Bdb> .

[aaltay]

#3994 add unit tests in the master branch. Once that is resolved, I will update this cherry pick.

[aaltay]

Added unit tests, PTAL.

[reuvenlax]

tests are failing, and some conflicts need to be resolved.

[aaltay]

retest this please

[aaltay]

Rebased.

Jenkins (python) tests are failing with some Jenkins related error: java.lang.NoClassDefFoundError: Could not initialize class jenkins.model.Jenkins$MasterComputer

cc: @klk @jasonkuster in case they have an idea about this.

[aaltay]

retest this please

[aaltay]

python tests failed after executing on beam8. Was not that worker blacklisted? (cc: @kennknowles)

[reuvenlax]

lgtm

[kennknowles]

I went in and did it manually, not through modifying all of our Groovy scripts. So the seed job will revert it. But it seems too odd to commit && !beam8 to the repo. We could, though. I didn't get a chance to chat w/ infra about it today.