Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-3049] Relocate everything shaded by Java SDK harness #4003

Merged
merged 1 commit into from Oct 17, 2017

Conversation

kennknowles
Copy link
Member

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

R: @herohde

Verified that everything in the shaded jar begins with org.apache.beam.fn.harness which is the current namespace adopted by the SDK harness code.

@kennknowles
Copy link
Member Author

kennknowles commented Oct 17, 2017

BTW the change from repackaged to private is deliberate, reflecting the whole point that these are private dependencies.

@kennknowles
Copy link
Member Author

run go precommit

Copy link
Member

@tgroh tgroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tgroh
Copy link
Member

tgroh commented Oct 17, 2017

I would grep or sed for uses of repackaged and replace them as appropriate.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 0089093 on kennknowles:harness-shading into ** on apache:master**.

@asfgit asfgit merged commit 0089093 into apache:master Oct 17, 2017
asfgit pushed a commit that referenced this pull request Oct 17, 2017
@kennknowles kennknowles deleted the harness-shading branch April 25, 2018 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants