[BEAM-3081] Findbugs: NonNull by default #4021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Very useful library, previously unavailable under an acceptable license. This is a compatible library reimplemented, discussed and now used by many Apache projects, including Avro, Falcon, Geode, HBase, Nifi, and Rya.
kennknowles
force-pushed
the
NonNull-by-default
branch
4 times, most recently
from
6b8e814
to
69663ab
Compare
kennknowles
force-pushed
the
NonNull-by-default
branch
from
69663ab
to
a1311d4
Compare
asfgit
pushed a commit
that referenced
this pull request
Oct 20, 2017
NonNull by default in metrics Ignore findbugs in AutoValue generated classes NonNull by default for sdk/testing NonNull by default in sdk/state NonNull by default in sdk/runners NonNull by default in sdk/annotations NonNull by default in sdk/coders Make Java core SDK root dir NonNull by default Add dep on Apache-licensed findbugs-annotations implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue.mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.R: @jkff since you mentioned the time findbugs spent, I thought I would try to get more value out of it anyhow.
I have wondered for a while why
@Nullableannotations didn't take care of themselves, since this is maybe the most important thing findbugs ought to be gaining us. Turns out it is simply turned off by default. It has to be turned on per-package, as far as I can tell. That is just as well, because some packages are in better shape than others.I addressed some low-hanging fruit to demonstrate, and the changes I made were universally improvements IMO, so that's nice evidence in favor of taking this further.