Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-2899] Copy runners.core.fn to java-fn-execution #4086

Closed
wants to merge 2 commits into from
Closed

[BEAM-2899] Copy runners.core.fn to java-fn-execution #4086

wants to merge 2 commits into from

Conversation

tgroh
Copy link
Member

@tgroh tgroh commented Nov 6, 2017 •
edited

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

This separates out utilities to interact with the Fn APIs, removing any
introduced dependency on the Beam Java SDK.

@tgroh tgroh force-pushed the move_core_fn_to_java_fn_execution branch 2 times, most recently from b09d14d to 58e7ea7 Compare November 7, 2017 16:40
@tgroh
Fork Control Clients into java-fn-execution
1f6ef2b 
Deprecate versions in runners-core. Runner-side portability APIs should
not have a dependency edge to an SDK, and use of the java-fn-execution
package ensures that.
@tgroh
Fork Data Service Libraries to java-fn-execution
e2f113a
@tgroh tgroh force-pushed the move_core_fn_to_java_fn_execution branch from 58e7ea7 to e2f113a Compare November 7, 2017 16:50
@tgroh
Copy link
Member Author

tgroh commented Nov 7, 2017

R: @kennknowles

@tgroh tgroh changed the title Move runners.core.fn to java-fn-execution Copy runners.core.fn to java-fn-execution Nov 7, 2017
@tgroh tgroh changed the title Copy runners.core.fn to java-fn-execution [BEAM-2899] Copy runners.core.fn to java-fn-execution Nov 7, 2017
kennknowles
kennknowles reviewed Nov 9, 2017
View reviewed changes
Copy link
Member

@kennknowles kennknowles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think perfectly safe to delete the old ones

kennknowles
kennknowles approved these changes Nov 9, 2017
View reviewed changes
Copy link
Member

@kennknowles kennknowles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to moving these bits, though.

@asfgit asfgit closed this in 727253e Nov 9, 2017
@tgroh tgroh mentioned this pull request Nov 9, 2017
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennknowles kennknowles kennknowles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tgroh @kennknowles