Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-3467] Remove Java 7 from the docker development images #4400

Merged
merged 1 commit into from Jan 13, 2018
Merged

[BEAM-3467] Remove Java 7 from the docker development images #4400

merged 1 commit into from Jan 13, 2018

Conversation

iemejia
Copy link
Member

@iemejia iemejia commented Jan 12, 2018

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@jbonofre jbonofre self-requested a review January 12, 2018 12:55
kennknowles
kennknowles approved these changes Jan 13, 2018
View reviewed changes
Copy link
Member

@kennknowles kennknowles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iemejia iemejia merged commit dc40445 into apache:master Jan 13, 2018
@iemejia
Copy link
Member Author

iemejia commented Jan 13, 2018

Thanks

@iemejia iemejia deleted the java8-update branch January 19, 2018 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennknowles kennknowles kennknowles approved these changes

@jbonofre jbonofre Awaiting requested review from jbonofre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iemejia @kennknowles