Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-3250] Migrate Flink ValidatesRunner to Gradle #4436

Merged
merged 1 commit into from Jan 24, 2018

Conversation

bsidhom
Copy link
Contributor

@bsidhom bsidhom commented Jan 18, 2018

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

The ValidatesRunner test configuration lives under runners/flink as in the Maven build. If accepted, this supersedes #4418.

@bsidhom
Copy link
Contributor Author

bsidhom commented Jan 18, 2018

r: @lukecwik
@kennknowles

@bsidhom
Copy link
Contributor Author

bsidhom commented Jan 18, 2018

Rebased to pull in project name refactoring.

@bsidhom
Copy link
Contributor Author

bsidhom commented Jan 18, 2018

r: @lukecwik

Copy link
Member

@lukecwik lukecwik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After looking at this approach and the other approach in #4418, this looks much nicer.

@lukecwik lukecwik merged commit 6affcb5 into apache:master Jan 24, 2018
@bsidhom bsidhom deleted the flink-validates-runner branch January 24, 2018 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants