Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-3249] Allow for re-use of dependencies within other projects by placing them within build_rules.gradle #4982

Merged
merged 1 commit into from Mar 30, 2018

Conversation

lukecwik
Copy link
Member


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand:
    • What the pull request does
    • Why it does it
    • How it does it
    • Why this approach
  • Each commit in the pull request should have a meaningful subject line and body.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@lukecwik lukecwik requested a review from tgroh March 30, 2018 18:31
@kennknowles
Copy link
Member

Just drive-by comment: A similar action that would make the project more idiomatic and result in fewer moving pieces would be to move the nature defs from build_rules.gradle into build.gradle (thus deleting build_rules.gradle). It would also make the code clearer since projects would be passed explicitly instead of implicitly global.

@lukecwik
Copy link
Member Author

lukecwik commented Mar 30, 2018

Kenn, Gradle doesn't work as you expect in this regard. Moving things out of build_rules.gradle into build.gradle would use the root project since it is in scope. This is why we are using apply from within each project so that when we define things like applyJavaNature, it uses the current project and its context.

@lukecwik lukecwik merged commit eb0bbe9 into apache:master Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants