[BEAM-2937] Update Portable Combine URNs to new URNs. #5128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
1 similar comment
|
retest this please |
youngoli
force-pushed
the
beam3706
branch
2 times, most recently
from
be88cf8
to
937a238
Compare
|
Run Python PreCommit |
1 similar comment
|
Run Python PreCommit |
|
R: @lukecwik |
lukecwik
approved these changes
May 18, 2018
| @@ -245,6 +245,25 @@ message StandardPTransforms { | |||
| COMBINE_PGBKCV = 0 [(beam_urn) = "beam:transform:combine_pgbkcv:v1"]; | |||
| COMBINE_MERGE_ACCUMULATORS = 1 [(beam_urn) = "beam:transform:combine_merge_accumulators:v1"]; | |||
| COMBINE_EXTRACT_OUTPUTS = 2 [(beam_urn) = "beam:transform:combine_extract_outputs:v1"]; | |||
|
|
|||
| // Represents the lifted part of a Combine.perKey() operation. Caches and | |||
There was a problem hiding this comment.
Better to refer to the name and point to the doc then the java code and a vague description.
Adding combine URNs based on the portable combines doc: https://s.apache.org/beam-runner-api-combine-model Keeping the old URNs to avoid breaking existing code.
lukecwik
approved these changes
May 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing combine URNs based on the portable combines doc:
https://s.apache.org/beam-runner-api-combine-model
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue.mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.