[BEAM-4044] [SQL] Make BeamCalciteTable self planning #5154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @kennknowles This is a refactor PR contained entirely in |
apilloud
force-pushed
the
cleanup
branch
2 times, most recently
from
25636a7
to
553b41c
Compare
|
run java precommit |
4 similar comments
|
run java precommit |
|
run java precommit |
|
run java precommit |
|
run java precommit |
kennknowles
approved these changes
Apr 20, 2018
kennknowles
reviewed
Apr 20, 2018
| @Override | ||
| public void flattenRel(RelStructuredTypeFlattener flattener) { | ||
| // rewriteGeneric calls this.copy. Setting isFlattining passes | ||
| // this context into copy for modificaiton of the flattened flag. |
apilloud
force-pushed
the
cleanup
branch
2 times, most recently
from
15f82d1
to
f873611
Compare
|
The set of findbugs tests run by maven and gradle are not the same. |
|
Personally, I think findbugs is not worthwhile once we have Errorprone or Checker. So anything expedient to get past this is fine by me. |
|
I dropped the Serializable from the table class, which should fix it. The error message suggests adding readObject which makes other code odities make more sense. |
|
LGTM |
mingmxu
approved these changes
Apr 24, 2018
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some cleanup moving us towards only using the calcite environment. This is required for calcite's builtin DDL support. There is no test changes, functional changes, or public API changes. The core nugget of this change is that the planner rules no longer require access to the BeamSqlEnv.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue.mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.