[BEAM-4255] Set singleton view writers' accumulation mode to discarding #5311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tgroh could you review this, please? |
tgroh
reviewed
May 8, 2018
| @@ -1283,6 +1283,10 @@ private GloballyAsSingletonView( | |||
| insertDefault, | |||
| insertDefault ? fn.defaultValue() : null, | |||
| combined.getCoder()); | |||
|
|
|||
| // GBK's inside view writers for singleton view should discard previous values. | |||
| materializationInput.setWindowingStrategyInternal(input.getWindowingStrategy() | |||
There was a problem hiding this comment.
You should instead use Window.configure().discardingFiredPanes(), explicitly setting any other required values from the upstream WindowingStrategy
There was a problem hiding this comment.
Window.configure() does not seem to work. I will take a little break from this bug and re-visit it soon.
|
run java precommit |
|
Using singletonView with Combine is generally flawed. Not continuing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code snippet below was writing multiple values to the sideInput, resulting in exception: "PCollection with more than one element accessed as a singleton view."
PCollectionView globalView = input
.apply(Window.into(new GlobalWindows())
.triggering(Repeatedly.forever(AfterPane.elementCountAtLeast(1)))
.accumulatingFiredPanes())
.apply(Sum.integersGlobally().asSingletonView())
This PR sets the accumulation mode to discarding for singleton view writer, so that the GBK's used by view writers do not accumulate combine results.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue../gradlew buildto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.