[BEAM-4267] Implement flink context factory methods #5573
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ArtifactSource argument used when creating DockerJobBundleFactory will be unushed until we finalize artifact retrieval on flink. Therefore we remove it until those plans are finalized.
axelmagn
force-pushed
the
flink-context-factories
branch
from
0311488
to
36bac7d
Compare
|
Do not merge yet. |
Implement the previously unsupported batchFactory and getStageBundleFactory methods within FlinkExecutableStageContext.
axelmagn
force-pushed
the
flink-context-factories
branch
from
36bac7d
to
d237323
Compare
bsidhom
reviewed
Jun 6, 2018
| @@ -37,11 +43,18 @@ | |||
| } | |||
|
|
|||
| public static Factory batchFactory() { | |||
| return null; | |||
| return jobInfo -> { | |||
There was a problem hiding this comment.
This "factory" should manage singleton state in this case. We want to make sure there's only a single instance of a DockerJobBundleFactory for a given job id. In order to do so, the factory itself needs to be a singleton.
|
As discussed offline, I'm going to hand this off to you (@bsidhom) since you have a branch with some work on this already, and it connects well with the other stuff you've been working on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the previously unsupported batchFactory and getStageBundleFactory methods within FlinkExecutableStageContext. These are the core methods relevant to BEAM-4267, but it does not close the bug.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.