Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ValidatesRunner_Apex #5604 #5666

Merged
merged 1 commit into from Jun 17, 2018
Merged

Conversation

tweise
Copy link
Contributor

@tweise tweise commented Jun 17, 2018

No description provided.

@tweise
Copy link
Contributor Author

tweise commented Jun 17, 2018

Run Apex ValidatesRunner

@tweise tweise requested review from iemejia and lukecwik June 17, 2018 06:44
@tweise tweise changed the title Fix ValidatesRunner_Apex #5604 [WIP] Fix ValidatesRunner_Apex #5604 Jun 17, 2018
@tweise
Copy link
Contributor Author

tweise commented Jun 17, 2018

Run Apex ValidatesRunner

@tweise tweise changed the title [WIP] Fix ValidatesRunner_Apex #5604 Fix ValidatesRunner_Apex #5604 Jun 17, 2018
Copy link
Member

@iemejia iemejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iemejia iemejia merged commit 6af4561 into apache:master Jun 17, 2018
@lukecwik
Copy link
Member

lukecwik commented Jun 18, 2018

Is there a reason why you wanted to add runners-core test scope instead of depending on hamcrest_core/hamcrest_library?

All the test failures have NoClassDef errors on org.hamcrest...

@lukecwik
Copy link
Member

Similar issue for Dataflow, opened #5671

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants