[BEAM-4643] Allow to check early panes of a window

[lhauspie]

Just adding the ability to check the early panes of a specific window (not only the global window).

Just by adding inEarlyPanes(BoundedWindow window) method in PAssert and its implementations, we are now capable of doing:

PAssert.that(teamScores)
    .inEarlyPanes(intervalWindow(05, 20))
        .containsInAnyOrder(
            KV.of("black", 1),  // First item (Black, 1)
            KV.of("black", 2))  // Second item (Black, 1) cumulated with the first one
    .inOnTimePane(intervalWindow(05, 20))
        .containsInAnyOrder(
            KV.of("black", 2))  // No new items since the last early element
    .inFinalPane(intervalWindow(05, 20))
        .containsInAnyOrder(
            KV.of("black", 10)); // New late data (black, 8)

NB: intervalWindow(05, 20) returns an new IntervalWindow from 00:05:00 to 00:20:00

Post-Commit Tests Status (on master branch)

Lang	SDK	Apex	Dataflow	Flink	Gearpump	Spark
Go		---	---	---	---	---
Java
Python		---		---	---	---

[kennknowles]

We have turned on autoformatting of the codebase, which causes small conflicts across the board. You can probably safely rebase and just keep your changes. Like this:

$ git rebase
... see some conflicts
$ git diff
... confirmed that the conflicts are just autoformatting
... so we can just keep our changes are do our own autoformat
$ git checkout --theirs --
$ git add -u
$ git rebase --continue
$ ./gradlew spotlessJavaApply

Please ping me if you run into any difficulty.

[lhauspie]

retest this please

[lhauspie]

I don't understand what's going wrong with the Jenkins Build.

On local, I've got the following outputs (BUILD SUCCESSFUL):

$ ./gradlew :beam-sdks-java-io-hadoop-input-format:test
    [...]
    > Task :beam-sdks-java-io-hadoop-input-format:testClasses
    
    > Task :beam-sdks-java-io-hadoop-input-format:test
    Java HotSpot(TM) Server VM warning: You have loaded library /tmp/libnetty-transport-native-epoll7569020236429498545.so which might have disabled stack guard. The VM will try to fix the stack guard now.
    It's highly recommended that you fix the library with 'execstack -c <libfile>', or link it with '-z noexecstack'.
    
    Deprecated Gradle features were used in this build, making it incompatible with Gradle 5.0.
    See https://docs.gradle.org/4.8/userguide/command_line_interface.html#sec:command_line_warnings
    
    BUILD SUCCESSFUL in 2m 3s
    53 actionable tasks: 41 executed, 12 up-to-date

$ ./gradlew :beam-sdks-java-io-elasticsearch-tests-2:test
    [...]
    > Task :beam-sdks-java-io-elasticsearch-tests-2:testClasses
    > Task :beam-sdks-java-io-elasticsearch-tests-2:test
    
    Deprecated Gradle features were used in this build, making it incompatible with Gradle 5.0.
    See https://docs.gradle.org/4.8/userguide/command_line_interface.html#sec:command_line_warnings
    
    BUILD SUCCESSFUL in 25s
    48 actionable tasks: 6 executed, 42 up-to-date

@kennknowles, could you please tell me if I introduced some bugs or did something wrong ?

[kennknowles]

I'm afraid I need to find another reviewere here. @reuvenlax can you take a look or pass it on?

[apilloud]

run java precommit

[apilloud]

ping @reuvenlax

[lhauspie]

retest this please

[lhauspie]

@lukecwik, does this PR need some actions from me or something else to be merged ?

Thanks in advance ;)

[akedin]

looking

[akedin]

retest this please

[akedin]

retest this please