[BEAM-4700] Convert Beam Row to Avatica Row in BeamEnumerableCollector #5849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennknowles
force-pushed
the
avatica-timestamp
branch
from
fbfa46f
to
0298c82
Compare
|
LGTM. Are there tests we should write? |
|
Yes, I'm pondering how to do this. I would like to get the DSL-level tests to run both as a PTransform and also through JDBC driver. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fairly surgical fix that makes timestamps work.
It is not at all a comprehensive solution to the general problem of establishing a proper compatibility between Beam
Rowand Avatica's meta schema stuff. I suspect we can overrideCursor.getAccessorsat the right place to avoid conversion at all. Since there's no meaningful documentation, it will take a minute to figure that out.Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)