Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-3249] Update the build script to be compatible with building Gradle within Google #5858

Merged
merged 2 commits into from Jul 2, 2018

Conversation

lukecwik
Copy link
Member

@lukecwik lukecwik commented Jul 2, 2018

  • Revert the extraMavenUrls since it isn't needed.
  • Disable the build scan plugin when running in offline mode.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status Build Status Build Status Build Status
Python Build Status --- Build Status
Build Status
--- --- --- ---

@lukecwik
Copy link
Member Author

lukecwik commented Jul 2, 2018

R: @markflyhigh
CC: @kennknowles @pabloem

@kennknowles
Copy link
Member

kennknowles commented Jul 2, 2018

Does build scan require online access just to be on the classpath? or just to be applied? My impression was the answer to both is "no". But whatever works. The other changes seem good since $GRADLE_HOME/init.d suffices for sandbox builds.

@lukecwik
Copy link
Member Author

lukecwik commented Jul 2, 2018

Your correct in saying that you don't need to be online to apply it as it disables itself and also won't run without --scan present. The issue is that we aren't sure what license the code is being distributed under and can't use it inside Google till the licensing question is resolved. The open source portion of Gradle is under Apache 2.0 but the build-scan plugin isn't open source and it is unclear what the license is, asked on the Gradle forum: https://discuss.gradle.org/t/what-is-the-build-scan-plugin-source-code-license/27585

@pabloem
Copy link
Member

pabloem commented Jul 2, 2018

Thanks Luke. This LGTM.

@lukecwik lukecwik changed the title Update the build script to be compatible with building Gradle within Google [BEAM-3249] Update the build script to be compatible with building Gradle within Google Jul 2, 2018
@markflyhigh
Copy link
Contributor

Thank you! LGTM

@lukecwik lukecwik merged commit 98534d9 into apache:master Jul 2, 2018
@kennknowles
Copy link
Member

Nice find. How unfortunate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants