Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-5039] Fix streaming_wordcount_it_test #6085

Merged
merged 3 commits into from
Jul 30, 2018

Conversation

udim
Copy link
Member

@udim udim commented Jul 27, 2018


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status Build Status Build Status Build Status
Python Build Status --- Build Status
Build Status
--- --- --- ---

@udim
Copy link
Member Author

udim commented Jul 27, 2018

run python postcommit

udim added 2 commits July 27, 2018 11:20
Also updates deprecation notice for Read/WriteStrings transforms to
2.7.0.
@udim
Copy link
Member Author

udim commented Jul 27, 2018

run python postcommit

@udim udim changed the title [BEAM-5039] Make with_attributes kwarg optional. [BEAM-5039] Fix streaming_wordcount_it_test Jul 27, 2018
@udim
Copy link
Member Author

udim commented Jul 27, 2018

R: @charlesccychen

@charlesccychen
Copy link
Contributor

Thanks! This LGTM.

@charlesccychen charlesccychen merged commit 531dd8b into apache:master Jul 30, 2018
@udim udim deleted the beam-5039 branch August 2, 2018 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants