[BEAM-3652] Port WriteWithShardingFactoryTest off DoFnTester #6527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Taking a look. Thanks! |
kennknowles
approved these changes
Oct 1, 2018
| @@ -163,74 +163,81 @@ public void withNoShardingSpecifiedReturnsNewTransform() { | |||
| } | |||
|
|
|||
| @Test | |||
| public void keyBasedOnCountFnWithNoElements() throws Exception { | |||
| @Category(ValidatesRunner.class) | |||
There was a problem hiding this comment.
The category here should not be necessary. This is a specialized transform just for the DirectRunner so the runner should be hardcoded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @kennknowles. I see that it is you reported this task. Can you review my solution for it?