[BEAM-2918] Add state support for batch in portable FlinkRunner #6740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxm
force-pushed
the
flink-batch-state
branch
from
64c0072
to
889b3f2
Compare
|
Run Python Flink ValidatesRunner |
|
Run Java Flink PortableValidatesRunner |
|
There is still an issue I'm working on. Will ping when this is ready for review. |
mxm
force-pushed
the
flink-batch-state
branch
from
889b3f2
to
31ea165
Compare
|
Run Python Flink ValidatesRunner |
|
Run Java Flink PortableValidatesRunner |
|
This is now ready for review. |
mxm
force-pushed
the
flink-batch-state
branch
from
31ea165
to
896da6c
Compare
|
Rebased to #6726 and enabled additional |
|
Run Python Flink ValidatesRunner |
|
Run Java Flink PortableValidatesRunner |
mxm
force-pushed
the
flink-batch-state
branch
from
896da6c
to
e152b6a
Compare
|
Rebased to master after #6726 was merged. |
|
Run Python Flink ValidatesRunner |
|
Run Java Flink PortableValidatesRunner |
|
@tweise Do you think you could take a look? |
tweise
reviewed
Oct 25, 2018
| @@ -595,4 +624,15 @@ private static void pruneOutput( | |||
| String.format("%s/out.%d", transformName, unionTag)); | |||
| context.addDataSet(collectionId, pruningOperator); | |||
| } | |||
|
|
|||
| private static <T> Coder<WindowedValue<T>> instantiateCoder( | |||
There was a problem hiding this comment.
Move this to FlinkPipelineTranslatorUtils ?
|
Looks good, just one minor suggestion. |
tweise
approved these changes
Oct 25, 2018
mxm
force-pushed
the
flink-batch-state
branch
from
29e1e1a
to
d558367
Compare
This adds portable state support for the batch mode.
MapState and SetState are not yet supported by the Fn client and need to be disabled.
mxm
force-pushed
the
flink-batch-state
branch
from
d558367
to
d448a96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds portable state support for the batch mode.
CC @tweise @angoenka @robertwb
Post-Commit Tests Status (on master branch)