Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-5817] Add SQL bounded side input join to queries that are actually run #7205

Merged
merged 1 commit into from Dec 5, 2018

Conversation

kennknowles
Copy link
Member

The benchmark was written and tested some time ago, but never run as part of our suite. This adds it so it should be run.


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status Build Status Build Status Build Status Build Status
Python Build Status --- Build Status
Build Status
Build Status --- --- ---

Copy link
Contributor

@akedin akedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennknowles
Copy link
Member Author

Run Java_Examples_Dataflow PreCommit

@kennknowles kennknowles merged commit a3510e0 into apache:master Dec 5, 2018
@kennknowles kennknowles deleted the sql-nexmark branch December 5, 2018 16:59
@echauchot
Copy link
Contributor

echauchot commented Dec 6, 2018

@kennknowles sorry I did not have time to take a look before merge, I'm a bit busy en spark runner right now.

pl04351820 pushed a commit to pl04351820/beam that referenced this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants