[BEAM-5918] Fix casting of non-numeric types #7373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @kennknowles |
|
Is this preempted by #6417 ? |
|
@kennknowles no, it isn't connected to Beam SQL #6417, it's transform from core |
|
Ah, sorry. Processing large post-holiday inbox too quickly and shallowly. I'll take a look. |
|
@kennknowles did you have a chance to take a look? |
kennknowles
reviewed
Jan 11, 2019
sdks/java/core/src/test/java/org/apache/beam/sdk/schemas/transforms/CastTest.java
Outdated
Show resolved
Hide resolved
|
LGTM if my comment is wrong. Nice code & tests, again. There's some conflict to be resolved. |
Simplify CastTest
kanterov
force-pushed
the
kanterov_fix_cast_test_4
branch
from
97427b9
to
6268dac
Compare
|
@kennknowles thanks for the review! I fixed the code and rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #7372.
Refactoring of tests, and fixing casting of non-numeric types that wasn't checked before.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)