[BEAM-6352] Revert PR#6467 to fix Watch transform #7540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think we should wait on the real fix for R: @kennknowles |
swegner
force-pushed
the
revert_pr6467
branch
3 times, most recently
from
716f08c
to
ca4f98e
Compare
…littableDoFns (apache#7016)" This reverts commit ef03439.
…lic API surface (apache#6467)" This reverts commit 413d852.
These tests were previously not running in our Jenkins test suites, and was broken during PR apache#6467. When the tests were added to Java precommit during PR apache#7374, it was discovered that these tests were broken. It turns out PR apache#6467 broke the Watch transform implementation, and has been rolled back until we come up with a proper fix.
swegner
force-pushed
the
revert_pr6467
branch
from
ca4f98e
to
f445705
Compare
|
Ok, tests are now passing locally. I believe this is ready to go. @kennknowles PTAL |
|
Nice. Thanks for putting this together! |
|
Would you prepare a cherry-pick against the release branch? |
This was referenced Jan 19, 2019
|
Cherry-pick: #7575 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Watchtransform tests were previously not running in our Jenkins test suites, andwas broken during PR #6467. When the tests were added to Java precommit
during PR #7374, it was discovered that these tests were broken.
It turns out PR #6467 broke the Watch transform implementation. This PR rolls back the changes and re-enables the tests until we come up with a proper fix.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)