Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-6593] Python 3 IT on DirectRunner in PreCommit #7734

Merged
merged 2 commits into from
Feb 5, 2019

Conversation

markflyhigh
Copy link
Contributor

@markflyhigh markflyhigh commented Feb 5, 2019

  • Add WordCountIT.test_wordcount_it on DirectRunner in PreCommit suite. The tests are added to gradle :beam-sdks-python-precommit-direct-py3 and can run in parallel with others.
  • In cleanPython, delete target directory which's used for tox build.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Python Build Status --- Build Status
Build Status
Build Status --- --- ---

@markflyhigh
Copy link
Contributor Author

cc: @tvalentyn @RobbeSneyders

@charlesccychen
Copy link
Contributor

Run Website PreCommit

1 similar comment
@markflyhigh
Copy link
Contributor Author

Run Website PreCommit

@charlesccychen
Copy link
Contributor

Thanks! This LGTM.

@charlesccychen
Copy link
Contributor

Website failures are unrelated and are fixed by #7740.

@charlesccychen charlesccychen merged commit 25051a5 into apache:master Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants