New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-4522] Re-enable CalcRemoveRule #7739

Merged

kennknowles merged 1 commit into apache:master from amaliujia:rw-enable_cal_remove_rule

Feb 6, 2019

Contributor

amaliujia commented Feb 5, 2019

CalcRemoveRule can be enabled.

Follow this checklist to help us incorporate your contribution quickly and easily:

Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.

Post-Commit Tests Status (on master branch)

Lang	SDK	Apex	Dataflow	Flink	Gearpump	Samza	Spark
Go		---	---	---	---	---	---
Java
Python		---			---	---	---


          [BEAM-4522] Re-enable CalcRemoveRule

83ad43b

Contributor Author

amaliujia commented Feb 5, 2019

Run Java PreCommit

Contributor Author

amaliujia commented Feb 5, 2019

kennknowles approved these changes

View reviewed changes

Member

kennknowles left a comment

Tests pass, so great! Was it the upgrade to Calcite 1.18.0 that fixed this or something else?

kennknowles merged commit 0eba0e4 into apache:master

amaliujia deleted the rw-enable_cal_remove_rule branch

February 6, 2019 04:54

Contributor Author

amaliujia commented Feb 6, 2019

Occasionally found the rule worked. Not sure why it's fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment