Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-6639] Retry pulling clickhouse-server docker image #7797

Merged

Conversation

kanterov
Copy link
Member

@kanterov kanterov commented Feb 9, 2019


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Python Build Status --- Build Status
Build Status
Build Status --- --- ---

@kanterov
Copy link
Member Author

kanterov commented Feb 9, 2019

Going to try out "Java PreCommit" several times and see if I can reproduce ClickHouseIO test failure

@kanterov
Copy link
Member Author

kanterov commented Feb 9, 2019

Run Java PreCommit

16 similar comments
@kanterov
Copy link
Member Author

kanterov commented Feb 9, 2019

Run Java PreCommit

@kanterov
Copy link
Member Author

kanterov commented Feb 9, 2019

Run Java PreCommit

@kanterov
Copy link
Member Author

kanterov commented Feb 9, 2019

Run Java PreCommit

@kanterov
Copy link
Member Author

kanterov commented Feb 9, 2019

Run Java PreCommit

@kanterov
Copy link
Member Author

kanterov commented Feb 9, 2019

Run Java PreCommit

@kanterov
Copy link
Member Author

kanterov commented Feb 9, 2019

Run Java PreCommit

@kanterov
Copy link
Member Author

Run Java PreCommit

@kanterov
Copy link
Member Author

Run Java PreCommit

@kanterov
Copy link
Member Author

Run Java PreCommit

@kanterov
Copy link
Member Author

Run Java PreCommit

@kanterov
Copy link
Member Author

Run Java PreCommit

@kanterov
Copy link
Member Author

Run Java PreCommit

@kanterov
Copy link
Member Author

Run Java PreCommit

@kanterov
Copy link
Member Author

Run Java PreCommit

@kanterov
Copy link
Member Author

Run Java PreCommit

@kanterov
Copy link
Member Author

Run Java PreCommit

@kanterov
Copy link
Member Author

@chamikaramj @kennknowles please take a look. The code is a bit dirty, but it seems to work, I wasn't able to reproduce test failure after 15 runs.

@kanterov
Copy link
Member Author

Run Java PreCommit

4 similar comments
@kanterov
Copy link
Member Author

Run Java PreCommit

@kanterov
Copy link
Member Author

Run Java PreCommit

@kanterov
Copy link
Member Author

Run Java PreCommit

@kanterov
Copy link
Member Author

Run Java PreCommit

@kanterov kanterov force-pushed the kanterov_retry_pull-clickhouse-server branch from d9ea9b4 to efe66f1 Compare February 13, 2019 19:05
@kanterov
Copy link
Member Author

@chamikaramj @kennknowles did you have a chance to check this out?

@kennknowles kennknowles self-requested a review February 20, 2019 04:44
Copy link
Member

@kennknowles kennknowles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kennknowles kennknowles merged commit 399de52 into apache:master Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants