[BEAM-6612] Improve java SDK performance by using a LinkedBlockingQueue in QueueingBeamFnDataClient #7895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajamato
force-pushed
the
buffering_queue_linked_blocking_queue
branch
from
cc51416
to
53b76b6
Compare
ajamato
changed the title
ajamato
force-pushed
the
buffering_queue_linked_blocking_queue
branch
2 times, most recently
from
12a8dcc
to
269952b
Compare
in QueueingBeamFnDataClient.
ajamato
force-pushed
the
buffering_queue_linked_blocking_queue
branch
from
269952b
to
5ccdd32
Compare
|
Run Java PreCommit |
ajamato
changed the title
|
R: @mdvorsky |
ajamato
changed the title
kennknowles
approved these changes
Mar 5, 2019
| @@ -65,6 +65,8 @@ public void complete() { | |||
|
|
|||
| @Override | |||
| public void fail(Throwable t) { | |||
| future.completeExceptionally(t); | |||
| // Use obtrudeException instead of CompleteExceptionally, forcing any future calls to .get() | |||
There was a problem hiding this comment.
Good catch. I did not realize that standard future behavior required this other function :-/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BEAM-6612] Improve java SDK performance by using a LinkedBlockingQueue in QueueingBeamFnDataClient
Now a small queue size is used instead of a synchronous queue which only held one element.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.