New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-6554] Adjust Jenkins directory for spotbugs report #7970
Conversation
R: @adude3141 |
@@ -42,7 +42,7 @@ builder.build { | |||
pattern('**/build/reports/checkstyle/*.xml') | |||
} | |||
findBugs { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason not to switch to spot bugs here?
Jenkins plugin also has that spotBugs() symbol (see [1], #81)
[1] https://github.com/jenkinsci/warnings-ng-plugin/blob/master/SUPPORTED-FORMATS.md
Run Java PreCommit |
Apart from this, reports are available on Jenkins status page. LGTM. Thx! |
Ah, stupid me.... we would need to run seed job first. Currently the 'results' are just the warning 'no files found' still LGTM, though |
Ah. I didn't realize I could switch |
run seed job |
https://builds.apache.org/job/beam_SeedJob/3553/console
|
Let's switch back to restore the signal and see if we care to fix that issue. |
run seed job |
run java precommit |
Well, at least now I know, why you kept that findBugs^^ Sorry for the confusion. Had expected that to simply work. I ll dig into the dsl plugin if I find the time... |
|
run java precommit |
Spotbugs has a compatible XML format, but puts the output in a different location.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.