Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-6554] Adjust Jenkins directory for spotbugs report #7970

Merged
merged 1 commit into from Mar 1, 2019

Conversation

kennknowles
Copy link
Member

Spotbugs has a compatible XML format, but puts the output in a different location.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Python Build Status
Build Status
--- Build Status
Build Status
Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@kennknowles
Copy link
Member Author

R: @adude3141

@@ -42,7 +42,7 @@ builder.build {
pattern('**/build/reports/checkstyle/*.xml')
}
findBugs {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to switch to spot bugs here?

Jenkins plugin also has that spotBugs() symbol (see [1], #81)

[1] https://github.com/jenkinsci/warnings-ng-plugin/blob/master/SUPPORTED-FORMATS.md

@adude3141
Copy link
Contributor

Run Java PreCommit

@adude3141
Copy link
Contributor

Apart from this, reports are available on Jenkins status page.

LGTM. Thx!

@adude3141
Copy link
Contributor

Ah, stupid me.... we would need to run seed job first. Currently the 'results' are just the warning 'no files found'

still LGTM, though

@kennknowles
Copy link
Member Author

Ah. I didn't realize I could switch findbugs to spotbugs. I'll do that too.

@kennknowles
Copy link
Member Author

run seed job

@kennknowles
Copy link
Member Author

kennknowles commented Mar 1, 2019

https://builds.apache.org/job/beam_SeedJob/3553/console

ERROR: Found multiple extensions which provide method spotBugs with arguments [job_PreCommit_Java$_run_closure1$_closure2$_closure3$_closure5$_closure7@390d42b]: [[io.jenkins.plugins.analysis.warnings.FindBugs, io.jenkins.plugins.analysis.warnings.SpotBugs]]

@kennknowles
Copy link
Member Author

Let's switch back to restore the signal and see if we care to fix that issue.

@kennknowles
Copy link
Member Author

run seed job

@kennknowles
Copy link
Member Author

run java precommit

@adude3141
Copy link
Contributor

adude3141 commented Mar 1, 2019

Well, at least now I know, why you kept that findBugs^^

Sorry for the confusion. Had expected that to simply work. I ll dig into the dsl plugin if I find the time...

@kennknowles
Copy link
Member Author

beam9 disconnected

@kennknowles
Copy link
Member Author

run java precommit

@kennknowles kennknowles merged commit 1a0407a into apache:master Mar 1, 2019
@kennknowles kennknowles deleted the spotbugs branch March 1, 2019 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants