Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-6869] fix dependency checking #8123

Merged
merged 1 commit into from Mar 25, 2019

Conversation

@yifanzou
Copy link
Contributor

yifanzou commented Mar 22, 2019

The dependency check was broken since the pyyaml yaml.load(file) was deprecated.
The dependency job passed with this PR https://builds.apache.org/view/A-D/view/Beam/view/All/job/beam_Dependency_Check/189/
Please review and merge.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Python Build Status
Build Status
--- Build Status
Build Status
Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@yifanzou

This comment has been minimized.

Copy link
Contributor Author

yifanzou commented Mar 22, 2019

Run Seed Job

@yifanzou

This comment has been minimized.

Copy link
Contributor Author

yifanzou commented Mar 22, 2019

Run Dependency Check

@yifanzou yifanzou force-pushed the yifanzou:BEAM-6869/fix_dependency_check branch from 6427673 to 4281832 Mar 22, 2019
@yifanzou

This comment has been minimized.

Copy link
Contributor Author

yifanzou commented Mar 22, 2019

Run Dependency Check

@yifanzou yifanzou force-pushed the yifanzou:BEAM-6869/fix_dependency_check branch from 4281832 to c0e5f04 Mar 22, 2019
@yifanzou

This comment has been minimized.

Copy link
Contributor Author

yifanzou commented Mar 22, 2019

Run Dependency Check

@yifanzou yifanzou force-pushed the yifanzou:BEAM-6869/fix_dependency_check branch 2 times, most recently from 272d664 to e2cf06d Mar 23, 2019
@yifanzou

This comment has been minimized.

Copy link
Contributor Author

yifanzou commented Mar 23, 2019

Run Dependency Check

@yifanzou yifanzou force-pushed the yifanzou:BEAM-6869/fix_dependency_check branch from e2cf06d to abe7cb9 Mar 23, 2019
@yifanzou

This comment has been minimized.

Copy link
Contributor Author

yifanzou commented Mar 23, 2019

Run Dependency Check

@yifanzou

This comment has been minimized.

Copy link
Contributor Author

yifanzou commented Mar 25, 2019

Run Seed Job

@yifanzou yifanzou force-pushed the yifanzou:BEAM-6869/fix_dependency_check branch from abe7cb9 to 7fb2a22 Mar 25, 2019
@yifanzou

This comment has been minimized.

Copy link
Contributor Author

yifanzou commented Mar 25, 2019

Run Dependency Check

@yifanzou yifanzou force-pushed the yifanzou:BEAM-6869/fix_dependency_check branch from 7fb2a22 to e9c535e Mar 25, 2019
@yifanzou

This comment has been minimized.

Copy link
Contributor Author

yifanzou commented Mar 25, 2019

Run Dependency Check

@yifanzou yifanzou force-pushed the yifanzou:BEAM-6869/fix_dependency_check branch from e9c535e to 73f09c4 Mar 25, 2019
@yifanzou yifanzou changed the title Do Not Merge [BEAM-6869] fix dependency checking [BEAM-6869] fix dependency checking Mar 25, 2019
@yifanzou

This comment has been minimized.

Copy link
Contributor Author

yifanzou commented Mar 25, 2019

@chamikaramj

This comment has been minimized.

Copy link
Contributor

chamikaramj commented Mar 25, 2019

LGTM. Thanks Yifan.

@chamikaramj chamikaramj merged commit 2c037fa into apache:master Mar 25, 2019
1 check passed
1 check passed
RAT ("Run RAT PreCommit") SUCCESS
Details
@yifanzou yifanzou deleted the yifanzou:BEAM-6869/fix_dependency_check branch Mar 25, 2019
@yifanzou

This comment has been minimized.

Copy link
Contributor Author

yifanzou commented Mar 25, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.