Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SQL] reject aggregation distinct rather than executing distinct as all #8498

Merged
merged 1 commit into from
May 7, 2019
Merged

[SQL] reject aggregation distinct rather than executing distinct as all #8498

merged 1 commit into from
May 7, 2019

Conversation

amaliujia
Copy link
Contributor

@amaliujia amaliujia commented May 4, 2019 •
edited

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status
Build Status
Build Status		 Build Status Build Status Build Status
Python Build Status
Build Status		 --- Build Status
Build Status		 Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@amaliujia
Copy link
Contributor Author

@TheNeuralBit

@amaliujia amaliujia changed the title [SQL] reject aggregation distinct rather than executing distinct as all. [SQL] reject aggregation distinct rather than executing distinct as all May 4, 2019
@TheNeuralBit
Copy link
Member

LGTM, thanks!

@amaliujia
Copy link
Contributor Author

@apilloud @akedin Could you help merge this PR?

@apilloud
Copy link
Member

apilloud commented May 7, 2019

LGTM.

@apilloud apilloud merged commit b93793d into apache:master May 7, 2019
@amaliujia amaliujia deleted the rw-reject_agg_distinct branch May 7, 2019 20:45
@amaliujia
Copy link
Contributor Author

Thanks!

@kennknowles kennknowles mentioned this pull request Jun 3, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@amaliujia @TheNeuralBit @apilloud