Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen upper limit for httplib2 #8653

Closed
wants to merge 1 commit into from
Closed

Loosen upper limit for httplib2 #8653

wants to merge 1 commit into from

Conversation

aaltay
Copy link
Member

@aaltay aaltay commented May 22, 2019

Current version on pypi is 0.12.3, we should be able to use patch versions in the same minor version.

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Python Build Status
Build Status
--- Build Status
Build Status
Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

Current version on pypi is 0.12.3, we should be able to use patch versions in the same minor version.
@aaltay aaltay requested a review from udim May 22, 2019 21:04
Copy link
Member

@udim udim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pip check is failing:

googledatastore 7.0.2 has requirement httplib2<=0.12.0,>=0.9.1, but you have httplib2 0.12.3

@aaltay
Copy link
Member Author

aaltay commented May 23, 2019

Arggh :/ Nevermind in that case, unless we change googledatastore to release 7.0.3 first this PR will not work.

I will check with googledatastore if they will be willing to do such a release.

@aaltay
Copy link
Member Author

aaltay commented May 23, 2019

Closing this for now. If googledatastore makes a new release, I can update both dependency versions. (Hopefully we will move away from googledatastore eventually.)

@aaltay aaltay closed this May 23, 2019
@aaltay aaltay deleted the aaltay-patch-1 branch May 23, 2019 00:20
@udim
Copy link
Member

udim commented May 23, 2019

Note that only the Python 2 based tests failed (docs and testPy2Gcp), because googledatastore is not a requirement in Python 3 environments. So if we really needed to we could upgrade httplib2 only for Py3.

🥇 pip check FTW. :)

@jinnovation
Copy link

@aaltay: Any news on bumping the dependency in googledatastore? My team at Twitter is looking to adopt a Beam dependent (TFX), and this specific pinned upper version limit for httplib2—as well as oauth2client—creates dependency conflict issues for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants