[BEAM-6693] replace mmh3 with default hash function #8780
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @tvalentyn |
|
Thanks, @Hannah-Jiang ! |
Hannah-Jiang
changed the title
…ng PCollection's PCoder (apache#8687) * Use TFRecord to store intermediate cache results using PCollection's PCoder. * Add optional support for TFRecord as a cache serialization format * Rename _Reader and _Writer to _reader_class and _writer_class * Clarify the return type of the CacheManager.read method
* Changes the code that picks the read method to use a switch statement. * Removes an unnecessary string concatenation.
Hannah-Jiang
force-pushed
the
mmh-upper-bound
branch
from
5ba3c74
to
21fb39a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change version upper bound for mmh3 to <3.0.0.
Update to: Replace mmh3 with default python hash function, because it's not reasonable to bring this inconvenience to production with only a little bit improvement with estimation for a loose estimation algorithm.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.