-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-4948, BEAM-6267, BEAM-5559, BEAM-7289] Update the version of guava to 26.0-jre for all our vendored artifacts containing guava #8899
Conversation
This is now ready for review since the vendored artifacts have been released. |
CC: @nymanjens |
Currently working through annotation issues with Guava upgrade as discussed in google/guava#920 and how they are incompatible with findbugs/spotbugs. |
…ava to 26.0-jre for all our vendored artifacts containing guava
…2objc annotations during compilation
…r clean-up of build module.
…ons in Guava 26.0-jre Further details in google/guava#920
Run Go PreCommit |
Run JavaPortabilityApi PreCommit |
Run Portable_Python PreCommit |
Run Python_PVR_Flink PreCommit |
Added @nonnull and suppressed the warning to address the spotbugs failures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM This is so harrd to get in with ongoing rebases and others that better to do it quickly.
Thanks Luke! LGTM. |
Please self merge. Have two minor comments:
|
The issue is that Guava migrated to the checkerframework |
Precommits are broken: https://issues.apache.org/jira/browse/BEAM-7784 |
FYI, there are 19 files under |
Original PR: apache#8899
…ava to 26.0-jre for all our vendored artifacts containing guava (apache#8899) * fixup! Address missing auto value annotations for spotbugs and also j2objc annotations during compilation * fixup! Fix used but undeclared deps for annotation deps, include minor clean-up of build module. * fixup! Address spotbugs issues with incompatible nullability annotations in Guava 26.0-jre Further details in google/guava#920 * [BEAM-4948, BEAM-6267, BEAM-5559, BEAM-7289] Update the version of guava to 26.0-jre for all our vendored artifacts containing guava
Original PR: apache#8899
…ava to 26.0-jre for all our vendored artifacts containing guava (apache#8899) * fixup! Address missing auto value annotations for spotbugs and also j2objc annotations during compilation * fixup! Fix used but undeclared deps for annotation deps, include minor clean-up of build module. * fixup! Address spotbugs issues with incompatible nullability annotations in Guava 26.0-jre Further details in google/guava#920 * [BEAM-4948, BEAM-6267, BEAM-5559, BEAM-7289] Update the version of guava to 26.0-jre for all our vendored artifacts containing guava
Original PR: apache#8899
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.