Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-7616] Add a timeout to urlopen calls #8925

Merged
merged 1 commit into from Jun 21, 2019
Merged

[BEAM-7616] Add a timeout to urlopen calls #8925

merged 1 commit into from Jun 21, 2019

Conversation

aaltay
Copy link
Member

@aaltay aaltay commented Jun 21, 2019

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Python Build Status
Build Status
--- Build Status
Build Status
Build Status --- --- Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@aaltay
Copy link
Member Author

aaltay commented Jun 21, 2019

R: @udim @ihji
cc: @akedin

@aaltay aaltay requested a review from udim June 21, 2019 17:03
Copy link
Contributor

@akedin akedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaltay
Copy link
Member Author

aaltay commented Jun 21, 2019

Run Python PostCommit

@aaltay aaltay merged commit 30c0dd8 into master Jun 21, 2019
@aaltay aaltay deleted the aaltay-patch-1 branch June 21, 2019 18:46
aaltay added a commit to aaltay/beam that referenced this pull request Jun 21, 2019
[BEAM-7616] Add a timeout to urlopen calls
aaltay added a commit to aaltay/beam that referenced this pull request Jun 21, 2019
akedin added a commit that referenced this pull request Jul 11, 2019
kennknowles added a commit to kennknowles/beam that referenced this pull request Jul 13, 2019
* github/pr/8927:
  Resolve merge conflict when cherry picking apache#8925
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants