[BEAM-7424] Retry HTTP 429 errors from GCS #8933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
match Python SDK retrying threshold to Java SDK threshold.
|
R: @chamikaramj |
|
CC: @robinyqiu |
chamikaramj
reviewed
Jun 26, 2019
| @@ -52,7 +52,7 @@ def __init__(self, url='', credentials=None, | |||
| super(StorageV1, self).__init__( | |||
| url, credentials=credentials, | |||
| get_credentials=get_credentials, http=http, model=model, | |||
| log_request=log_request, log_response=log_response, | |||
| log_request=log_request, log_response=log_response, num_retries=20, | |||
There was a problem hiding this comment.
This client is autogenerated so this code might get replaced when this client is generated next time. Can you also send a PR to apitools so that the default number of retries is increased for the GCS client.
|
LGTM. Thanks. |
|
Run Python PreCommit |
|
run python precommit |
|
Run Python PreCommit |
4 similar comments
|
Run Python PreCommit |
|
Run Python PreCommit |
|
Run Python PreCommit |
|
Run Python PreCommit |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matching Python SDK GCS retrying threshold to Java SDK GCS retrying threshold.
For Java SDK, retrying threshold for GCS is 15 min. To match the similar threshold in Python SDK, the maximum number of retry is increased to 20.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.